Skip to content

Document timeout for access checks

Amy Qualls requested to merge 31068-aqualls-access-check-timeout into master

What does this MR do?

  • ./development/architecture.md Added cross-link to internal_api.md
  • ./development/maintenance_mode.md Added cross-link to internal_api.md
  • ./development/internal_api.md See below.
  • ./administration/gitaly/index.md Added cross-link to internal_api.md
  • ./administration/logs.md Code examples.
  • ./administration/reference_architectures/troubleshooting.md Added cross-link to internal_api.md
  • ./administration/troubleshooting/log_parsing.md Code example.
  • ./administration/troubleshooting/debug.md Added two cross-links to internal_api.md

What needs review:

  • My changes to ./development/internal_api.md - I did a minor text formatting change, and I added a line acknowledging the 50 second limit. Is there another place / way I should be providing this info?
  • Code examples exist in ./administration/logs.md, ./administration/troubleshooting/log_parsing.md I'd appreciate a quick check by an engineer to see if the response formats need an update.

Reassigning to @sean_carroll for review. @m_gill, thanks for pinging me!

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec

  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods

  • Security reports checked/validated by a reviewer from the AppSec team

  • Related to #31068

  • Related to https://gitlab.com/gitlab-org/create-stage/-/issues/41

Edited by Amy Qualls

Merge request reports