Skip to content

Remove capybara specs relying on jQuery.ajax

Lukas 'ai-pi' Eipert requested to merge remove-broken-tests into master

What does this MR do?

We had some capybara specs that checked whether expanding a diff calls the Backend more than once. These specs have been broken since we are using axios. Unfortunately as they are testing a negative, they never failed.

We are removing those specs in favor of new JS unit tests which actually test that the API is called exactly once.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports