Skip to content

Refactor code coverage summary graphql resolver

Max Orefice requested to merge mo-coverage-finder-graphql-cleanup into master

Ref: #293825 (closed)

What does this MR do?

This MR refactors our CodeCoverageSummary resolver for our GraphQL API to use our new DailyBuildGroupReportResultsFinder.

Why are we doing this?

Now that we've extended our finder to be more flexible, we can start removing some duplicated code in our resolver to clean up more ~"technical debt".

This will allow us to centralize all our database business logic in our new finder.

Database review

Please note that we did not change our existing query introduced in !45831 (merged).

We just moved our business logic to our dedicated finder.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports