Resolve "Improve compliance frameworks form UI/UX"
What does this MR do?
This MR resolves the following issues with compliance frameworks form UI/UX:
- (!55592 (dea5a783)) The add forms submit button should say "Add framework" not "Save changes"
- (!55592 (c48bd673)) On successful submission of the form, the form should not be reshown while waiting for the redirection to take place
- (!55592 (322d4fb9)) The success banner on the listing is marked as dismissable but doesn't actually dismiss: !54224 (comment 515680449)
Setup & Testing
- Enable the development feature flag in rails console:
Feature.enable(:ff_custom_compliance_frameworks)
- Navigate to a group's general settings
[GDK_HOST]/groups/gitlab-org/-/edit#js-compliance-frameworks-settings
- Add a compliance framework
Screenshots (strongly suggested)
Button text
Loading behaviour
Alert dismiss
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because hidden behind a feature flag
.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321974 (closed)
Merge request reports
Activity
changed milestone to %13.10
added typefeature label
added 2 commits
- 087c816a - Update add forms submit btn text to "Add framework"
- 3a0a9eed - Update forms to show loading when redirecting
1 Warning ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on throughput implementation.
- The definition of done documentation.
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 55592 "Resolve "Improve compliance frameworks form UI/UX""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 55592 "Resolve "Improve compliance frameworks form UI/UX""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Tom Quirk ( @tomquirk
) (UTC+9.5, 7.5 hours ahead of@jiaan
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 3.5 hours ahead of@jiaan
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
@rob.hunt as a groupcompliance expert with context here could you please review this MR?
🙏
requested review from @rob.hunt
- Resolved by Kushal Pandya
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f0cff10a and 322d4fb9
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.18 MB 3.18 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Danger@kushalpandya would you mind doing the maintainer review for this MR?
🙏 requested review from @kushalpandya
mentioned in commit 5599a664
added workflowstaging label and removed workflowplanning breakdown label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label