Skip to content
Snippets Groups Projects

Resolve "Improve compliance frameworks form UI/UX"

Merged Jiaan Louw requested to merge 321974-improve-compliance-frameworks-form-ui-ux into master
All threads resolved!

What does this MR do?

This MR resolves the following issues with compliance frameworks form UI/UX:

  1. (!55592 (dea5a783)) The add forms submit button should say "Add framework" not "Save changes"
  2. (!55592 (c48bd673)) On successful submission of the form, the form should not be reshown while waiting for the redirection to take place
  3. (!55592 (322d4fb9)) The success banner on the listing is marked as dismissable but doesn't actually dismiss: !54224 (comment 515680449)

Setup & Testing

  1. Enable the development feature flag in rails console: Feature.enable(:ff_custom_compliance_frameworks)
  2. Navigate to a group's general settings [GDK_HOST]/groups/gitlab-org/-/edit#js-compliance-frameworks-settings
  3. Add a compliance framework

Screenshots (strongly suggested)

Button text

Before After
image image

Loading behaviour

Before After
Kapture_2021-03-03_at_16.43.43 Kapture_2021-03-03_at_16.27.01

Alert dismiss

Before After
Kapture_2021-03-03_at_16.45.53 Kapture_2021-03-03_at_16.38.57

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321974 (closed)

Edited by Jiaan Louw

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jiaan Louw
  • Jiaan Louw requested review from @rob.hunt

    requested review from @rob.hunt

  • Jiaan Louw
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits f0cff10a and 322d4fb9

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.18 MB 3.18 MB - 0.0 %
    mainChunk 1.95 MB 1.95 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

  • Robert Hunt approved this merge request

    approved this merge request

  • @kushalpandya would you mind doing the maintainer review for this MR? 🙏

  • Robert Hunt requested review from @kushalpandya

    requested review from @kushalpandya

  • Kushal Pandya approved this merge request

    approved this merge request

  • Kushal Pandya resolved all threads

    resolved all threads

  • merged

  • Kushal Pandya mentioned in commit 5599a664

    mentioned in commit 5599a664

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading