Skip to content

Allow rotations to gracefully switch between parameters

Sarah Yasonik requested to merge 262862-switch-rotation-params into master

What does this MR do?

Related issue: #262862

This MR adds logic for when a user takes manual action on a rotation (create or edit) and we want to have the effect take place immediately on the saved shifts.

  • For new rotations which have already "started", we will simply trim the first shift to start at the creation time of the rotation.
  • For edited rotations (!55258 (merged)), the old parameters and the new parameters may conflict, leading to errors in saving shifts. This is prevented by cutting the existing oncall shift short, and immediately starting a new one partway through.
  • If there is no existing saved shift or no new shift, as might happen when a rotation has active periods, nothing will happen.

Screenshots

Example: I created a rotation at 8:15pm which started before today called "Cut me off yo". You can see the start time of the new shift is trimmed to the creation time.

Screen_Shot_2021-03-02_at_8.30.01_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports