Allow rotations to gracefully switch between parameters
What does this MR do?
Related issue: #262862
This MR adds logic for when a user takes manual action on a rotation (create or edit) and we want to have the effect take place immediately on the saved shifts.
- For new rotations which have already "started", we will simply trim the first shift to start at the creation time of the rotation.
- For edited rotations (!55258 (merged)), the old parameters and the new parameters may conflict, leading to errors in saving shifts. This is prevented by cutting the existing oncall shift short, and immediately starting a new one partway through.
- If there is no existing saved shift or no new shift, as might happen when a rotation has active periods, nothing will happen.
Screenshots
Example: I created a rotation at 8:15pm which started before today called "Cut me off yo". You can see the start time of the new shift is trimmed to the creation time.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
-
I have not included a changelog entry because this is not a user-facing change.
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen