Skip to content

On call rotation interval follow ups

Tristan Read requested to merge tr-on-call-rotation-interval-follow-ups into master

What does this MR do?

Addresses review feedback from !54280 (merged)

Changes:

  • Component: Break out direct $emit calls into a helper method
  • Specs: Prefer trigger over $emit in specs where possible.

Feature flag: :oncall_schedules_mvc

Screenshots (strongly suggested)

No visual changes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports