Introduce group-level API for devops adoption
What does this MR do?
Adds additional filtering options for Devops adoption segments, which will be used at FE side for group level devops adoption. Also enables devops adoption API for group-level usage.
Screenshots (strongly suggested)
Query explains
Finder query: https://console.postgres.ai/gitlab/gitlab-production-tunnel/sessions/2495/commands/7614
Query
SELECT "analytics_devops_adoption_segments"."id" AS t0_r0, "analytics_devops_adoption_segments"."last_recorded_at" AS t0_r1, "analytics_devops_adoption_segments"."created_at" AS t0_r2, "analytics_devops_adoption_segments"."updated_at" AS t0_r3, "analytics_devops_adoption_segments"."namespace_id" AS t0_r4, "namespaces"."id" AS t1_r0, "namespaces"."name" AS t1_r1, "namespaces"."path" AS t1_r2, "namespaces"."owner_id" AS t1_r3, "namespaces"."created_at" AS t1_r4, "namespaces"."updated_at" AS t1_r5, "namespaces"."type" AS t1_r6, "namespaces"."description" AS t1_r7, "namespaces"."avatar" AS t1_r8, "namespaces"."membership_lock" AS t1_r9, "namespaces"."share_with_group_lock" AS t1_r10, "namespaces"."visibility_level" AS t1_r11, "namespaces"."request_access_enabled" AS t1_r12, "namespaces"."ldap_sync_status" AS t1_r13, "namespaces"."ldap_sync_error" AS t1_r14, "namespaces"."ldap_sync_last_update_at" AS t1_r15, "namespaces"."ldap_sync_last_successful_update_at" AS t1_r16, "namespaces"."ldap_sync_last_sync_at" AS t1_r17, "namespaces"."description_html" AS t1_r18, "namespaces"."lfs_enabled" AS t1_r19, "namespaces"."parent_id" AS t1_r20, "namespaces"."shared_runners_minutes_limit" AS t1_r21, "namespaces"."repository_size_limit" AS t1_r22, "namespaces"."require_two_factor_authentication" AS t1_r23, "namespaces"."two_factor_grace_period" AS t1_r24, "namespaces"."cached_markdown_version" AS t1_r25, "namespaces"."project_creation_level" AS t1_r26, "namespaces"."runners_token" AS t1_r27, "namespaces"."file_template_project_id" AS t1_r28, "namespaces"."saml_discovery_token" AS t1_r29, "namespaces"."runners_token_encrypted" AS t1_r30, "namespaces"."custom_project_templates_group_id" AS t1_r31, "namespaces"."auto_devops_enabled" AS t1_r32, "namespaces"."extra_shared_runners_minutes_limit" AS t1_r33, "namespaces"."last_ci_minutes_notification_at" AS t1_r34, "namespaces"."last_ci_minutes_usage_notification_level" AS t1_r35, "namespaces"."subgroup_creation_level" AS t1_r36, "namespaces"."emails_disabled" AS t1_r37, "namespaces"."max_pages_size" AS t1_r38, "namespaces"."max_artifacts_size" AS t1_r39, "namespaces"."mentions_disabled" AS t1_r40, "namespaces"."default_branch_protection" AS t1_r41, "namespaces"."unlock_membership_to_ldap" AS t1_r42, "namespaces"."max_personal_access_token_lifetime" AS t1_r43, "namespaces"."push_rule_id" AS t1_r44, "namespaces"."shared_runners_enabled" AS t1_r45, "namespaces"."allow_descendants_override_disabled_shared_runners" AS t1_r46, "namespaces"."traversal_ids" AS t1_r47, "namespaces"."delayed_project_removal" AS t1_r48 FROM "analytics_devops_adoption_segments" LEFT OUTER JOIN "namespaces" ON "namespaces"."id" = "analytics_devops_adoption_segments"."namespace_id" WHERE "analytics_devops_adoption_segments"."namespace_id" IN (WITH RECURSIVE "base_and_descendants" AS ((SELECT "namespaces".* FROM "namespaces" WHERE "namespaces"."type" = 'Group' AND "namespaces"."id" = 9970)
UNION
(SELECT "namespaces".* FROM "namespaces", "base_and_descendants" WHERE "namespaces"."type" = 'Group' AND "namespaces"."parent_id" = "base_and_descendants"."id")) SELECT "namespaces"."id" FROM "base_and_descendants" AS "namespaces") ORDER BY "namespaces"."name" ASC
Plan
Explain
Sort (cost=2254.94..2255.39 rows=181 width=380) (actual time=0.028..0.029 rows=0 loops=1)
Sort Key: namespaces.name
Sort Method: quicksort Memory: 25kB
Buffers: shared hit=4
-> Nested Loop Left Join (cost=1591.51..2248.15 rows=181 width=380) (actual time=0.004..0.005 rows=0 loops=1)
Buffers: shared hit=1
-> Merge Semi Join (cost=1591.08..1625.17 rows=181 width=36) (actual time=0.003..0.004 rows=0 loops=1)
Merge Cond: (analytics_devops_adoption_segments.namespace_id = namespaces_1.id)
Buffers: shared hit=1
-> Index Scan using index_analytics_devops_adoption_segments_on_namespace_id on public.analytics_devops_adoption_segments (cost=0.15..29.40 rows=850 width=36) (actual time=0.002..0.002 rows=0 loops=1)
Buffers: shared hit=1
-> Sort (cost=1590.93..1591.38 rows=181 width=4) (actual time=0.000..0.000 rows=0 loops=0)
Sort Key: namespaces_1.id
-> CTE Scan on base_and_descendants namespaces_1 (cost=1578.71..1582.33 rows=181 width=4) (actual time=0.000..0.000 rows=0 loops=0)
CTE base_and_descendants
-> Recursive Union (cost=0.43..1578.71 rows=181 width=344) (actual time=0.000..0.000 rows=0 loops=0)
-> Index Scan using index_namespaces_on_type_and_id_partial on public.namespaces namespaces_2 (cost=0.43..3.45 rows=1 width=344) (actual time=0.000..0.000 rows=0 loops=0)
Index Cond: (((namespaces_2.type)::text = 'Group'::text) AND (namespaces_2.id = 9970))
-> Nested Loop (cost=0.56..157.16 rows=18 width=344) (actual time=0.000..0.000 rows=0 loops=0)
-> WorkTable Scan on base_and_descendants (cost=0.00..0.20 rows=10 width=4) (actual time=0.000..0.000 rows=0 loops=0)
-> Index Scan using index_namespaces_on_parent_id_and_id on public.namespaces namespaces_3 (cost=0.56..15.68 rows=2 width=344) (actual time=0.000..0.000 rows=0 loops=0)
Index Cond: (namespaces_3.parent_id = base_and_descendants.id)
Filter: ((namespaces_3.type)::text = 'Group'::text)
Rows Removed by Filter: 0
-> Index Scan using namespaces_pkey on public.namespaces (cost=0.43..3.44 rows=1 width=344) (actual time=0.000..0.000 rows=0 loops=0)
Index Cond: (namespaces.id = analytics_devops_adoption_segments.namespace_id)
Execution time
Time: 2.170 ms
- planning: 1.688 ms
- execution: 0.482 ms
- I/O read: N/A
- I/O write: N/A
Shared buffers:
- hits: 4 (~32.00 KiB) from the buffer pool
- reads: 0 from the OS file cache, including disk I/O
- dirtied: 0
- writes: 0
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321087 (closed)
Edited by Pavel Shutsin