Show API errors when a command-only comment fails
What does this MR do?
For #287686 (closed)
This MR displays the actual error(s) returned by the API when it fails.
This MR only addresses the known case of an error when the comment is a command only, which returns a 422 and the response.data.errors.commands_only errors list.
| MR | Notes |
|---|---|
| !55427 (merged) | Since we're going to be touching strings and i18n values, this MR cleans up the existing i18n into a single central location for the Notes app |
| We're here |
New branched logic to show Flash messages specific to command-only errors |
Screenshots (strongly suggested)
| Before | After | |
|---|---|---|
| Single Error |  |
 |
| Multiple Errors | Multiple errors can't be shown in the current setup, but even if we could, the way the deprecated Flash (currently in use) works, it would only show the last error. |  |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph