Skip to content

Do not break words in the code blocks under Safari

Vitaly Slobodin requested to merge vs-wrap-code-lines-blocks-properly into master

What does this MR do?

In !54540 (merged) we landed a fix to break the single (inline) code lines but the fix broke the code blocks in Safari. Apparently, Safari does not like the overflow-wrap CSS property and we should add word-wrap for it. This merge request resolves that and restores the following behaviors:

  • Single (inline) code line must be wrapped.
  • Code blocks must not be wrapped.

Screenshots (strongly suggested)

Before

Safari 14.0.3 (16610.4.3.1.4) Google Chrome (88.0.4324.192 (Official Build) (x86_64) Firefox 86.0
image image image

After (Only Safari is affected)

Safari 14.0.3 (16610.4.3.1.4) Google Chrome (88.0.4324.192 (Official Build) (x86_64) Firefox 86.0
image image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vitaly Slobodin

Merge request reports