Refactor pipelines table to GlTable
What does this MR do?
This refactor is behind the new_pipelines_table
feature flag. To test this locally open your rails console and enable the mentioned flag. Then you can view pipelines and MR pipelines to ensure the table is still working like it should.
First MR: !54958 (merged)
This is the second MR where we build out the table. We make three wrapper components to move data validation into.
pipelines_commit.vue
pipeline_operations.vue
pipeline_commit.vue
I move the related logic out of pipelines_table_row.vue
into these components, do the validation and pass down. This is because the architecture has changed using GlTable
.
UX changes
- Added duration heading
- Using
GlTable
changes heading font weight and padding a bit on the table - Left align duration cell text
- Mobile operation buttons are not full width due to CSS limitations.
Related to: #321257 (closed)
Screenshots (strongly suggested)
Desktop
flag off | flag on |
---|---|
![]() |
![]() |
![]() |
![]() |
Mobile
flag off | flag on |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [ - ] Changelog entry
- [ - ] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [ - ] Database guides
- [ - ] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [ - ] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team