Skip to content

Add prevent approval by committers to group-level MR approval settings

Jiaan Louw requested to merge 247903-add-prevent-approval-to-group-level into master

What does this MR do?

This MR adds a Prevent approval of merge requests by merge request committers setting to the group-level Merge request approvals settings as described in #247903 (closed).

Setup & Testing

  1. Enable the feature flag echo "Feature.enable(:group_merge_request_approval_settings_feature_flag)" | rails c
  2. View the Merge request approvals settings at [GDK_HOST]/groups/[GROUP]/-/edit
  3. Toggle the checkbox and refresh the page to see if the setting persists

Screenshots (strongly suggested)

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #247903 (closed)

Edited by Jiaan Louw

Merge request reports