Move to btn-confirm from btn-success in the groups directory
What does this MR do?
Move to btn-confirm from btn-success in the groups directory
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
👋 @yoThank you for your contributions to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
Our Merge Request coaches will ensure your contribution is reviewed in a timely manner.
To bring your merge request to the attention of the relevant team within GitLab, you can ask our bot to label it with a group label. For example, if your merge request changes a project management feature, it can be labelled by commenting
@gitlab-bot label ~"group::project management"
. To find the most relevant group for your change, you can look up the group based on the most relevant product category in the product categories table. Once you have found the group name, type@gitlab-bot label ~group::
, then start to type the group name and select the applicable group label, then submit the comment and the bot will apply the label for you.If after a few days, there's no message from a GitLab team member, feel free to ping
@gitlab-org/coaches
or ask for help by commenting@gitlab-bot help
.These resources may help you to move your Merge Request to the next steps:
This message was generated automatically. You're welcome to improve it.
added Community contribution label
marked the checklist item Changelog entry as completed
As a part of #320731 (closed)
mentioned in issue gitlab-org/quality/triage-reports#2179 (closed)
added Category:Importers UX devopsfoundations frontend + 1 deleted label
added UI polish label and removed Category:Importers UX devopsfoundations frontend + 1 deleted label
added Category:Importers UX devopsfoundations frontend + 1 deleted label
added 715 commits
-
399cf36b...37d862c3 - 712 commits from branch
gitlab-org:master
- 80e27e1e - Move to btn-confirm from btn-success in groups directory
- cbe84552 - Add Changelog
- d1182321 - Update btn-confirm-group.yml
Toggle commit list-
399cf36b...37d862c3 - 712 commits from branch
- Resolved by Olena Horal-Koretska
@ohoral could you review this community contribution? Thanks
assigned to @yo
requested review from @ohoral
4 Warnings ⚠ d1182321: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ cbe84552: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ This merge request does not refer to an existing milestone. ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer ~changelog No reviewer available No maintainer available frontend Zack Cuddy ( @zcuddy
) (UTC-6)Phil Hughes ( @iamphill
) (UTC+0)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 09f7b555 and d1182321
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.17 MB 3.17 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Dangermentioned in commit ddeee4e7
added workflowstaging label
added workflowcanary label and removed workflowstaging label
changed milestone to %13.10
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added groupimport and integrate label and removed 1 deleted label