Add Allow force push option to Protected branches
What does this MR do?
Add Allow force push option to Protected branches.
This MR provides a more convenient way to allow force push for users/groups with push access on protected branches.
Issues: #15611 (closed), #9407
Note: changes in this MR are behind the :allow_force_push_to_protected_branches feature flag.
Migrations
rake db::migrate
WARNING: This version of GitLab depends on gitlab-shell 13.16.1, but you're running 13.15.0. Please update gitlab-shell.
== 20210225153522 AddAllowForcePushToProtectedBranches: migrating =============
-- add_column(:protected_branches, :allow_force_push, :boolean, {:default=>false, :null=>false})
-> 0.0046s
== 20210225153522 AddAllowForcePushToProtectedBranches: migrated (0.0047s) ====rake db:rollback
WARNING: This version of GitLab depends on gitlab-shell 13.16.1, but you're running 13.15.0. Please update gitlab-shell.
== 20210225153522 AddAllowForcePushToProtectedBranches: reverting =============
-- remove_column(:protected_branches, :allow_force_push, :boolean, {:default=>false, :null=>false})
-> 0.0081s
== 20210225153522 AddAllowForcePushToProtectedBranches: reverted (0.0107s) ====Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Mycroft Kang