Skip to content

Feat(incidents): add issue state to alerts table

David O'Regan requested to merge 228733-alert-issue-status into master

What does this MR do?

A tiny MVC for #228733 (closed) to add the status of an issue to the alert table alongside its issue number.

We handle this by doing a few things:

  1. Swapping the issue_iid on the alert_type.rb for the full issue itself.
  2. Add a preload lookahead to the alert_resolver.rb to stop any N+1 issues and add specs to cover it as prescribed: https://docs.gitlab.com/ee/development/api_styleguide.html#verifying-with-tests
  3. Break out the alert issue into a separate set of specs for easier code management.
  4. Update the Alert management, details component, and the corresponding specs to use the issue object to access iid and state rather than just iid.

Screenshots (strongly suggested)

Screenshot_2021-03-01_at_14.51.20

Screenshot_2021-03-01_at_14.51.28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #228733 (closed)

Edited by David O'Regan

Merge request reports