Skip to content

Replace the `group_hooks.feature` spinach test with an rspec analog

blackst0ne requested to merge blackst0ne-replace-spinach-group-hooks.feature into master

What does this MR do?

This MR moves all the tests from the features/group_hooks.feature spinach spec to an rspec analog.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Spinach removal campaign.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

gitlab-ce#23036

Edited by blackst0ne

Merge request reports