Skip to content

Group integration settings buttons to the left

Tom Quirk requested to merge move-cancel-btn-integrations into master

What does this MR do?

Moves Cancel button to be grouped with other buttons (on the left hand side) to conform with Pajamas: https://design.gitlab.com/components/button/#dos-and-dont%E2%80%99s

Also updates the Save Settings modal button to confirm variant

Screenshots (strongly suggested)

Before After
Screen_Shot_2021-02-25_at_2.43.50_pm Screenshot_2021-02-25_at_2.37.52_pm
Screen_Shot_2021-02-25_at_2.44.11_pm Screen_Shot_2021-03-03_at_4.37.24_pm
Screen_Shot_2021-02-25_at_2.43.29_pm Screen_Shot_2021-03-03_at_4.41.33_pm
Screen_Shot_2021-02-25_at_2.46.10_pm Screen_Shot_2021-02-25_at_2.39.35_pm
Screen_Shot_2021-03-03_at_4.40.45_pm Screen_Shot_2021-03-03_at_4.40.01_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports