Add tracking to merge request time estimate/spent changes [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

We need to track how many users change the time estimate and spent for MRs.

To get that, whenever the time estimate and spent changes for a merge request, we track the following events:

• i_code_review_user_time_estimate_changed
• i_code_review_user_time_spent_changed

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #292824 (closed)

changed milestone to %13.10

added Deliverable backend devopscreate groupcode review sectiondev labels

changed the description

added 1 commit

• 4b5d252a - Track usage pings when time estimate/spent changes

Compare with previous version

changed title from Track usage pings when time estimate/spent changes to Track usage pings when time estimate/spent changes [RUN ALL RSPEC] [RUN AS-IF-FOSS]

1 Warning

⚠

For the following files, a review from the Data team and Product Intelligence team is recommended Please check the product intelligence guide and reach out to @gitlab-org/growth/product-intelligence/engineers group for a review. config/feature_flags/development/usage_data_i_code_review_user_time_estimate_changed.yml config/feature_flags/development/usage_data_i_code_review_user_time_spent_changed.yml lib/gitlab/usage_data_counters/aggregated_metrics/code_review.yml lib/gitlab/usage_data_counters/known_events/code_review_events.yml lib/gitlab/usage_data_counters/merge_request_activity_unique_counter.rb spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb config/metrics/counts_28d/20210301102134_i_code_review_user_time_estimate_changed_monthly.yml config/metrics/counts_28d/20210301102204_i_code_review_user_time_spent_changed_monthly.yml config/metrics/counts_7d/20210302103539_i_code_review_user_time_estimate_changed_weekly.yml config/metrics/counts_7d/20210302103615_i_code_review_user_time_spent_changed_weekly.yml doc/development/usage_ping/dictionary.md

	2 Messages
📖	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.
📖	You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS] (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.

Documentation review

The following files require a review from a technical writer:

• doc/development/usage_ping/dictionary.md

The review does not need to block merging this merge request. See the:

• Technical Writers assignments for the appropriate technical writer for this review.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Tiger Watson (@tigerwnz) (UTC+13, 5 hours ahead of @patrickbajao)	Stan Hu (@stanhu) (UTC-8, 16 hours behind @patrickbajao)
~changelog	No reviewer available	No maintainer available
~feature_flag	No reviewer available	No maintainer available

If needed, you can retry the danger-review job that generated this comment.

Generated by 🚫 Danger

added product intelligence product intelligencereview pending labels

added 1 commit

• 9b13a882 - Track usage pings when time estimate/spent changes

Compare with previous version

Hi @acroitor, can you please review this as backend reviewer?

Hi @mikolaj_wawrzyniak, can you please review this from product intelligence perspective?

Thanks all! 🙇

assigned to @acroitor and @mikolaj_wawrzyniak

mentioned in issue #18407 (closed)

approved this merge request

unassigned @patrickbajao, @acroitor, and @mikolaj_wawrzyniak

added 472 commits

• 9b13a882...5ed8c2a6 - 471 commits from branch master
• cdf9b9c6 - Track usage pings when time estimate/spent changes

Compare with previous version

added 1 commit

• dca57978 - Update usage ping dictionary

Compare with previous version

assigned to @smcgivern and @mikolaj_wawrzyniak

added documentation label

assigned to @patrickbajao

approved this merge request

unassigned @smcgivern

mentioned in merge request !55374 (merged)

unassigned @patrickbajao

assigned to @patrickbajao and unassigned @mikolaj_wawrzyniak

added 204 commits

• dca57978...7539bb17 - 202 commits from branch master
• 607d9113 - Add tracking to merge request time estimate/spent changes
• ceac968a - Update usage ping dictionary

Compare with previous version

changed title from Track usage pings when time estimate/spent changes [RUN ALL RSPEC] [RUN AS-IF-FOSS] to Add tracking to merge request time estimate/spent changes [RUN ALL RSPEC] [RUN AS-IF-FOSS]

assigned to @mikolaj_wawrzyniak

added 228 commits

• ceac968a...37814a05 - 226 commits from branch master
• c2fa94c4 - Add tracking to merge request time estimate/spent changes
• 6b990d27 - Update usage ping dictionary

Compare with previous version

added 62 commits

• 6b990d27...e5df1467 - 60 commits from branch master
• f125b2ac - Add tracking to merge request time estimate/spent changes
• ab9c269d - Update usage ping dictionary

Compare with previous version

added product intelligenceapproved label and removed product intelligencereview pending label

approved this merge request

unassigned @mikolaj_wawrzyniak

assigned to @smcgivern

resolved all threads

enabled an automatic merge when the pipeline for 4996f4cc succeeds

merged

mentioned in commit ce8d6350

mentioned in issue gitlab-com/gl-infra/scalability#905

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

added featureenhancement typefeature labels