Skip to content

Cache /search/count requests in the browser

Dylan Griffith requested to merge 300150-cache-search-tab-counters into master

What does this MR do?

These requests are typically loaded by the same user repeatedly as they switch tabs on the search page. Considering that Elasticsearch indexing is only updated every 1-2 minutes anyway the 1 minute browser side cache shouldn't really be noticeable to users except for loading counts faster.

This is also using a private cache (default for expires_in) so that it is not cached by intermediate proxies. This is important since each user's permissions is considered in a search.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300150 (closed)

Edited by Dylan Griffith

Merge request reports