Skip to content

Throw an error when yaml mode contains unparsable attributes

Sam White requested to merge protect_fix_l7_policies into master

What does this MR do?

Issue: #271169 (closed)

This MR fixes an error that occurs on the Security & Compliance -> Threat Monitoring -> Policies page. When users create or edit a policy and enter L7 policies in yaml mode, the L7 portion of the policy is currently removed from the yaml if the user then switches into rule mode. The desired behavior is to throw an error instead of stripping the policy. This update fixes that bug by checking whether or not the user-entered yaml contains any attributes that we do not recognize.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports