Skip to content

Differentiate MR Approval Settings from Approval Rules

Austin Regnery requested to merge ar-approval-settings-header into master

What does this MR do?

Adds a header for Approval settings for greater context, and cleans up the checkbox styling

Screenshots (strongly suggested)

Before After
Screenshot_2021-02-23_Push_Rules___Admin_Area_1_ Screenshot_2021-03-12_Push_Rules___Admin_Area
Screenshot_2021-02-23_General___Settings___Gitlab_Org_Gitlab_Shell_1_ Screenshot_2021-03-12_General___Settings___Gitlab_Org_Gitlab_Shell

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322643 (closed)

Edited by Austin Regnery

Merge request reports