Remove graphql_logging feature flag code [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Removes graphql_logging feature flag which was already enabled by default. #35579 (closed)
GQL query analyzers can define an analyze? method to conditionally analyze the query. I removed the method definition as it is not mandatory to define it and will be executed https://graphql-ruby.org/queries/ast_analysis.html#conditional-analysis
This works now, but it will probably change when we opt-it to the new AST analyzer as the docs state we should inherit from GraphQL::Analysis::AST::Analyzer where the analyze? method is defined and defaults to true.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #35579 (closed)