Skip to content

Replace "type" prop with events in stage.vue

Miguel Rincon requested to merge 300403-remove-type-from-minipipeline-stage into master

What does this MR do?

Remove "type" prop from stage

The "type" prop in the stage is used to decide if an event should be triggered in the eventHub object, but using an single event bind is easier to track.

Screenshots (strongly suggested)

Pipeline table refresh works the same as before:

2021-02-23_18.18.37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300403 (closed)

Edited by Miguel Rincon

Merge request reports