Skip to content

Rename `jira_issues_list_root.vue` to `jira_issues_import_status_app.vue`

Tom Quirk requested to merge rename-jira-issues-list-root-component into master

What does this MR do?

There are currently 2 files in the codebase named jira_issues_list_root.

Only one of them is actually as the name describes: a list of Jira issues : https://gitlab.com/gitlab-org/gitlab/blob/master/ee/app/assets/javascripts/integrations/jira/issues_list/components/jira_issues_list_root.vue

The other (the subject of this MR) appears to be used to display the status of a Jira issue import. This MR renames the files and related classes to be more meaningful.

Note: some CSS has been removed in favor of a fix in gitlab-ui => gitlab-ui!2042 (merged)

This feature is currently behind the vue_issuables_list feature flag, disabled by default. To enable it, run Feature.enable(:vue_issuables_list) in the rails console

Screenshots (strongly suggested)

Before After
Screen_Shot_2021-02-23_at_3.48.15_pm Screen_Shot_2021-02-23_at_3.48.01_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports