Skip to content

Refactor the Geo LogCursor Logger to make class more descriptive

Toon Claes requested to merge tc-geo-fix-daemon-log-class into master

What does this MR do?

To make the source class more descriptive, i.e. including all the parent module names, the Logger used by the Geo LogCursor is refactored to be a class. The caller should instantiate it and pass it it's class so the logger can extract it's name.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ee#5632.

Edited by Nick Thomas

Merge request reports