Skip to content

Fix mounted event issues on invite members banner

Doug Stull requested to merge 301221-fix-loading-issue-banner into master

What does this MR do?

No changelog

  • Code that uses it is behind a feature flag and other code it may affect is developer facing.

Troubleshooting steps that led to this conclusion(snowplow must be configured and enabled for your instance to see this under general instance settings - can point to localhost for URL)

  1. Replicated the issue on .com we can see below the Snowplow tracker is not configured yet when our banner loads.

    Screen_Shot_2021-02-19_at_6.50.16_PM

  2. For Show page(Group overview): Replicated the issue locally, we see from console logging messages our ordering of initialization is not correct. (already added the listener for details page to show the difference). A failed post means the tracker is initialized, but can't make it to snowplow since I am using a local setup(this is good and the tracker is configured).

    Screen_Recording_2021-02-22_at_9.34.42_AM

  3. For Details page(Details): Similar to the above for Show - we can see the unconfigured tracker. (reload hits show where I had already added the listener)

    Screen_Recording_2021-02-22_at_9.31.30_AM

  4. Finally - showing no unconfigured trackers once flush pending added.

    Screen_Recording_2021-02-22_at_9.33.33_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #301221

Edited by Doug Stull

Merge request reports