Save usage_data_id from versions app in raw_usage_data
requested to merge 292698-save-usage_data_id-raw_data_id-we-receive-from-versions-in-raw_usage_data into master
What does this MR do?
This modifies SubmitUsagePingService
to save usage_data_id
from
version-gitlab-com app to help correlate records from gitlab-com's RawUsageData
with
those stored in the versions app, as previously this was only possible
by relying on recorded_at
.
Database migration output
❯ bundle exec rake db:migrate:down VERSION=20210219211845
== 20210219211845 AddVersionUsageDataIdToRawUsageData: reverting ==============
-- remove_column(:raw_usage_data, :version_usage_data_id_value, :bigint)
-> 0.0016s
== 20210219211845 AddVersionUsageDataIdToRawUsageData: reverted (0.0024s) =====
❯ bundle exec rake db:migrate
== 20210219211845 AddVersionUsageDataIdToRawUsageData: migrating ==============
-- add_column(:raw_usage_data, :version_usage_data_id_value, :bigint)
-> 0.0019s
== 20210219211845 AddVersionUsageDataIdToRawUsageData: migrated (0.0019s) =====
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #292698 (closed)
Edited by Piotr Skorupa