Skip to content

Change default_enabled value of FF in usage data

Furkan Ayhan requested to merge change-default_enabled-of-usage_data-FFs into master

What does this MR do?

While working on an issue, I realized that we don't consider the default_enabled value of each individual usage_data_xxx feature flags. We assume they are enabled by default.

It is recently introduced that we can use default_enabled: :yaml for feature flag checks.

In this MR, I changed the usage of Feature.enabled?(:"usage_data_#{event_name}", default_enabled: true) to Feature.enabled?(:"usage_data_#{event_name}", default_enabled: :yaml) in Gitlab::Utils::UsageData.

Usage data feature flags that have default_enabled: false in their YAML definitions:

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan

Merge request reports