Alternative approach to Report any cyclic dep error when seeding build
pedropombeiro/26345/6-add-expand_variable_collection branch, please change to master before merging
What does this MR do?
This is the seventh MR in a Russian-doll style chain of 8 MRs culminating with !48627 (merged). It:
- Adds
Ci::Build#variables_collectionandBuild::Context::Base, that gets called from#variables; - Leverages those methods to add logic in
Pipeline::Seed::Buildto create an error if an error is detected in the sorting of variables.
Note: in comparison with the alternative of !54509 (merged) + !54563 (merged), this alternative version doesn't remove #scoped_variables_hash, in order to reduce the scope of changes.
List of MRs
MR 1: MakeCollection::Sortedclass take and output aVariables::Collection;MR 2: Add#sorted_collectionmethod and#errorsproperty toVariables::Collection;-
MR 3: Add indexing/lookup of variables to
Variables::Collection; -
MR 4: Add support for
depends_onproperty toVariables::Collection::Item; -
MR 5: Add support for
rawproperty toVariables::Collection::Item; -
MR 6: Add an
#expand_variables_collectionfunction toExpandVariablesto perform a full expansion of aVariables::Collection, gated by the new project-scoped:variable_inside_variablefeature flag. It will return the original object if a cyclic reference is detected; - MR 7: Add error reporting to
Gitlab::Ci::Pipeline::Seed::Buildto let the user know when a problem occurs with variable expansion; -
MR 8: Change
Ci::BuildRunnerPresenter#variablesto leverageExpandVariables#expand_variables_collectionso that variables sent in the job response are expanded;
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Part of gitlab-runner#26345 (closed)
Edited by Pedro Pombeiro