Skip to content

Fix wording in Danger when warning about number of lines changed

Manoj M J requested to merge manojmj-master-patch-66037 into master

What does this MR do?

This change fixes the wording slightly when Danger warns about "too many lines changed" in an MR.

Example of warning generated by Danger today

This merge request is quite big  (more than 547 lines changed), please consider splitting it into multiple merge requests.

The MR in question contains changes in exactly 547 lines, so the more than wording prefixed with it can be avoided.

With this fix, the warning would be like:

This merge request is quite big  (547 lines changed), please consider splitting it into multiple merge requests.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports