Skip to content

Update default title of alerts to New: Alert

Sarah Yasonik requested to merge sy-update-alert-title into master

What does this MR do?

Related issue: #299046 (closed)

When an alert is sent to gitlab without a title, we should name the alert as 'New: Alert'; when an incident is created from an alert, the title should be changed from 'New: Alert' to 'New: Incident' instead, preserving the added 'iid' for the incident in the title.

Screenshots

Testing:

  1. Create a new HTTP Integration under Settings > Operations > Alerts
  2. Send a test alert with an empty payload
  3. See the alert under Operations > Alert
  4. Create an incident
  5. See the incident title
New alert New incident from alert
Screen_Shot_2021-02-18_at_4.08.32_PM Manual issue creation: Screen_Shot_2021-02-18_at_4.56.20_PM Screen_Shot_2021-02-18_at_4.08.47_PM
Screen_Shot_2021-02-18_at_4.57.55_PM Automatic issue creation: Screen_Shot_2021-02-18_at_4.56.26_PM Screen_Shot_2021-02-18_at_5.19.16_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports