Add GPG keys list view to Admin Credentials Inventory
What does this MR do?
This MR adds the GPG keys table view to the Admin credentials inventory. The revoke and delete action buttons will be added via future issues.
This feature is behind the feature flag :credential_inventory_gpg_keys
.
Screenshots (strongly suggested)
Large screens | Small screens | Dark mode |
---|---|---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- Enable the feature flag
:credential_inventory_gpg_keys
- Add GPG keys to your user
[GDK_HOST]/-/profile/gpg_keys
- Go to
[GDK_HOST]/admin/credentials?filter=gpg_keys
- Check that the GPG key is shown
- Disable the feature flag and check that the GPG keys tab is hidden from the admin credentials inventory
To get a verified GPG key:
- Take the email address used for the GPG key and update your user to use that email address:
/-/profile
- Find your user in the rails console
User.find(1)
and retrieve the confirmation tokenuser.confirmation_token
- Go to the URL
[GDK_HOST]/users/confirmation?confirmation_token=[CONFIRMATION_TOKEN]
- Check the GPG keys tab and it should show the GPG key is verified
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #282429 (closed)
Edited by Robert Hunt