Enable customize homepage banner by default [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
- Converts experimental feature flag to default enabled development feature flag.
- After one milestone we'll then remove this feature flag altogether via #299895
Test locally(GDK)
-
Register for a new user in the UI
-
Click on the homepage logo in nav on far left
-
Ensure banner is seen as below
-
In rails console, disable the feature flag
[2] pry(main)> Feature.disable(:customize_homepage) -
Refresh page(may need to be refreshed a few times as the FF cache is invalidated)
-
Ensure no banner is seen.
Screenshots
with banner
without banner
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #299895
Edited by Doug Stull