Skip to content

Fix search functionality in Jira issues list

Justin Ho Tuan Duong requested to merge 321040-jira-list-search-not-working into master

What does this MR do?

A recent change (still unidentified) changed the way FilteredSearchBar sends back its filters object in the onFilter event.

In particular, the free text filter changed from a string value to an object with the key filtered-search-term. This caused an regression in the Jira issues list as we were lacking specs around the free text search functionality.

This fix updates the code to follow the next object structure and adds specs to make sure it doesn't break again.

Screenshots (strongly suggested)

Jira issues list search (with multiple search tokens)

http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/integrations/jira/issues?state=opened&page=1&sort=created_desc&search=test+issue

Jira_issues_list_search

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321040 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports