Skip to content

Add support to animate slide for settings-block component

Tan Le requested to merge 321512-support-slide-animation-settings-block into master

What does this MR do?

Add support to animate slide for settings-block component.

This commit adds an extra prop slideAnimated to settings-block shared component which control slide animation. By default, slide animation is enabled so it stays consistent with existing setting blocks in haml template.

📷 Screenshots

Before After
no_slide slide_animated

How to test

There are currently only two pages using this shared component:

*Behind feature flag group_merge_request_approval_settings_feature_flag

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #321512 (closed)

Edited by Tan Le

Merge request reports