Add support to animate slide for settings-block component
What does this MR do?
Add support to animate slide for settings-block
component.
This commit adds an extra prop slideAnimated
to settings-block
shared component which control slide animation. By default, slide
animation is enabled so it stays consistent with existing setting blocks
in haml template.
📷 Screenshots
Before | After |
---|---|
![]() |
![]() |
How to test
There are currently only two pages using this shared component:
- Group > Settings > Merge Approval Settings (http://gdk.test:3000/groups/gitlab-org/-/settings)*
- Group > Settings > Packages and Registries (http://gdk.test:3000/groups/gitlab-org/-/settings/packages_and_registries)
*Behind feature flag group_merge_request_approval_settings_feature_flag
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #321512 (closed)
Edited by Tan Le