Skip to content

Fix retried value for commit statuses [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Furkan Ayhan requested to merge fix-default-value-for-retried into master

What does this MR do?

We are trying to remove Ci:: ProcessPipelineService#update_retried method because we think it shouldn't be used anymore. We realized that this method is still necessary for some cases where we directly generate CommitStatus.

First, we added a metric to see if we use this method, then decided to fix those cases.

This MR fixes those cases.

This MR introduces two feature flags:

  • ci_fix_commit_status_retried #321631 (closed) => This enables to assign "retried" for older commit statuses in some cases.
  • ci_remove_update_retried_from_process_pipeline #321630 (closed) => This disables the usage of #update_retried method.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports