Add wait after resolving all threads in issue and shared example
What does this MR do?
I noticed 4 flaky specs when resolving threads in an MR with a new issue and took a look to find the screenshots all show that the failure occurred on the MR page.
I added a wait_for_all_requests
prior to checking the shared example to see if the behavior is more consistent.
Failure screenshots
- https://gitlab.com/gitlab-org/gitlab/-/jobs/1031389585/artifacts/file/tmp/capybara/resolving_all_open_threads_in_a_merge_request_from_an_issue_as_a_user_with_access_to_the_project_for.png
- https://gitlab.com/gitlab-org/gitlab/-/jobs/1023552373/artifacts/file/tmp/capybara/resolving_all_open_threads_in_a_merge_request_from_an_issue_as_a_user_with_access_to_the_project_for.png
- https://gitlab.com/gitlab-org/security/gitlab/-/jobs/1009635565/artifacts/file/tmp/capybara/resolving_all_open_threads_in_a_merge_request_from_an_issue_as_a_user_with_access_to_the_project_for.png
- https://gitlab.com/gitlab-org/gitlab/-/jobs/992276108/artifacts/file/tmp/capybara/resolving_all_open_threads_in_a_merge_request_from_an_issue_as_a_user_with_access_to_the_project_for.png
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #321252 (closed), #301156 (closed), #300290 (closed), #273568 (closed)
Edited by Kyle Wiebers