Skip to content

Add wait after resolving all threads in issue and shared example

Kyle Wiebers requested to merge 321252-add-wait into master

What does this MR do?

I noticed 4 flaky specs when resolving threads in an MR with a new issue and took a look to find the screenshots all show that the failure occurred on the MR page.

I added a wait_for_all_requests prior to checking the shared example to see if the behavior is more consistent.

Failure screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #321252 (closed), #301156 (closed), #300290 (closed), #273568 (closed)

Edited by Kyle Wiebers

Merge request reports