Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 38,038
    • Issues 38,038
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,345
    • Merge requests 1,345
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !54232

Merged
Created Feb 15, 2021 by Jonas Wälter@wwwjonContributor7 of 7 tasks completed7/7 tasks

Add API endpoint /application/plan_limits for package file size limits

  • Overview 47
  • Commits 11
  • Pipelines 13
  • Changes 11

What does this MR do?

In the UI, the "Package file size limits" can be defined in the application settings (Settings > CI/CD > Package Registry):

Package_file_size_limits

However, these settings are not accessible via the API.

In this MR, the following package file size settings of the default plan are integrated into the API endpoint GET/PUT /application/settings (see current documentation). According to the discussion in this MR, it's not desired that the settings are included into the API endpoint /application/settings. Instead, it was requested that the plan limits should be outsourced to a new, separate API endpoint.

So in this MR, a new API endpoint /application/plan_limits is implemented to allow you to maintain the application limits for the existing subscription plans. The plan limits can now be read and modified directly through the API.

Category:API api backend

🛠 with ❤ at Siemens

/cc @bufferoverflow

Screenshots

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers
  • [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited Feb 22, 2021 by Jonas Wälter
Assignee
Assign to
Reviewer
Request review from
13.10
Milestone
13.10 (Past due)
Assign milestone
Time tracking
Source branch: feat/api-application-settings-package-file-size-limits