Remove fallback logic

What does this MR do?

Part of #321678 (closed)

This change was suggested in a review comment.

Remove fallback logic for license, from and to in HistoricalData#max_historical_user_count by moving it outside of this method. The scope of this refactor got a bit bigger than expected with the footprint of that method.

HistoricalData#in_license_term was moved to License (License#historical_data) as it seemed fitting with the removal of its fallback values.

This shouldn't need a changelog since it falls under:

Any developer-facing change (e.g., refactoring, technical debt remediation, test suite changes) should not have a changelog entry. Example: “Reduce database records created during Cycle Analytics model spec.”

Does this MR meet the acceptance criteria?


Availability and Testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Corinna Gogolok