Skip to content

Add ability to delete a compliance framework via groups settings

Jiaan Louw requested to merge 287847-add-delete-compliance-framework-button into master

What does this MR do?

This MR adds a delete icon & confirmation modal for compliance frameworks.

Issue: #287847 (closed)

Setup & Testing

  1. Enable the feature flag in rails console: Feature.enable(:ff_custom_compliance_frameworks)
  2. Add a compliance framework using the GraphQL query !48250 (merged)
  3. [alternative method] Add a compliance framework in rails console:
FactoryBot.definition_file_paths = [Rails.root.join('ee', 'spec', 'factories')]
FactoryBot.find_definitions

project = Group.find_by_full_path('gitlab-org').projects.first

FactoryBot.create(:compliance_framework_project_setting, :sox, project: project)
  1. View the compliance frameworks at [GDK_HOST]/groups/gitlab-org/-/edit

Screenshots (strongly suggested)

Before After
image image
Screen capture
Kapture_2021-02-19_at_10.23.41

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #287847 (closed)

Edited by Jiaan Louw

Merge request reports