Add ability to delete a compliance framework via groups settings
What does this MR do?
This MR adds a delete
icon & confirmation modal for compliance frameworks.
Issue: #287847 (closed)
Setup & Testing
- Enable the feature flag in rails console:
Feature.enable(:ff_custom_compliance_frameworks)
- Add a compliance framework using the GraphQL query !48250 (merged)
- [alternative method] Add a compliance framework in rails console:
FactoryBot.definition_file_paths = [Rails.root.join('ee', 'spec', 'factories')]
FactoryBot.find_definitions
project = Group.find_by_full_path('gitlab-org').projects.first
FactoryBot.create(:compliance_framework_project_setting, :sox, project: project)
- View the compliance frameworks at
[GDK_HOST]/groups/gitlab-org/-/edit
Screenshots (strongly suggested)
Before | After |
---|---|
Screen capture |
---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry -
Behind a feature flag
- [-] Documentation (if required) -
Behind a feature flag
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #287847 (closed)
Edited by Jiaan Louw