Skip to content

Resolve "Flaky test spec/models/release_highlight_spec.rb[1:1:1:1]"

What does this MR do?

Fix flaky tests related to memoization in ReleaseHighlights.file_paths.

ReleaseHighlights.file_paths memoizes the value in @file_paths class instance variable. When this class method is called across multiple tests, the values persist across tests.

When a test job runs spec/requests/whats_new_controller_spec.rb followed by spec/models/release_highlight_spec.rb, the test in the first file calls and memoizes @file_paths. When the latter tests from release_highlight_spec.rb calls .file_paths again, it uses the memoized values.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #321526 (closed)

Edited by Mayra Cabrera

Merge request reports