Migrate import_projects application to gitlab-ui
What does this MR do?
Non-trivial changes
| Before | After | Notes |
|---|---|---|
.import-projects-loading-icon { margin-top: $gl-padding-32; } |
gl-mt-7 |
|
.import-table .import-jobs-from-col .., { border-bottom-width: 1px; padding-left: $gl-padding; } |
gl-border-b-1 gl-pl-5 |
.import_table, columns classes kept, see below |
.table-responsive { display: block; width: 100%; overflow-x: auto; } |
gl-w-full |
overflow-x dropped intentionally, display: block is already in effect - used on div |
.table td { padding: 0.75rem; vertical-align: top; border-top: 1px solid #404040; } |
gl-p-4 gl-vertical-align-top gl-gl-border-0 gl-border-solid border-t-1 gl-border-gray-100 |
|
.import-project-name-input |
Eliminated, replaced with better approach | |
.import-slash-divider |
Eliminated, replaced with better approach | |
.import-row { height: 55px; } |
gl-h-11 |
|
Trivial changes
| Before | After |
|---|---|
| d-flex | gl-display-flex |
| flex-wrap | gl-flex-wrap |
| justify-content-between | gl-justify-content-space-between |
| align-items-center | gl-align-items-center |
| mb-3 | gl-mb-5 |
| mt-2 | gl-mt-3 |
| text-center | gl-text-center |
| text-nowrap | gl-white-space-nowrap |
| light | gl-text-gray-900 |
Kept classes
-
qa-project-*for QA reasons -
import-jobs-*-col- maintain specific widths, specified in page bundle import.css
All removed CSS belongs to page bundle which is included only on project import / group import and verified as not used on group import page
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #235977 (closed)
Edited by Illya Klymov