Skip to content

Allow users to save group MR approval settings

Tan Le requested to merge 285458-group-request-approval-update-action into master

What does this MR do?

This MR is a follow-up of !52297 (merged) which adds the ability to save Group MR approval settings.

This feature is currently hidden behind a feature flag: group_merge_request_approval_settings_feature_flag.

📷 Screenshots

The new section is available at Group Settings > General (http://localhost:3000/groups/gitlab-org/-/edit)

Screen_Shot_2021-01-28_at_11.44.28_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #285458 (closed)

Edited by Tan Le

Merge request reports