Skip to content

Switch to Vue without runtime compiler

Lukas 'ai-pi' Eipert requested to merge leipert-vue-experiment into master

What does this MR do?

This allows us to ship a much smaller build of Vue in production and forces folks to use Vue SFC with templates rather than defining templates in HAML which is prone to XSS due to an additional layer of indirection. We are already linting against new usage of this pattern with our eslint rule: @gitlab/no-runtime-template-compiler

We still support compilation from Strings in Jest tests though.

Information to validate the efficacy of this MR can be found in this comment: !53922 (comment 674907952)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Greiling

Merge request reports