Skip to content

Use parseBoolean for canEdit when mounting iteration_select.vue

euko requested to merge use-parse-boolean-for-iteration-can-edit-value into master

What does this MR do?

Fix 1

When user can't edit iteration, canEdit data attribute should be parsed using parseBoolean to prevent this error:

Screen_Shot_2021-02-10_at_3.00.40_PM

(parseBoolean is already used elsewhere in mount_sidebar.js)

Fix 2

We should have used .to_s to convert can_edit_issuable to string in _sidebar.html.haml. (this is only noticeable once we start parsing canEdit with parseBoolean.)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports