Skip to content

Draft: Search tabs fix resetting params on tab change

What does this MR do?

Related to #262066 (closed)

Found while testing !52018 (merged) in staging. This fixes two issues found:

  • Reset Filter link was not working as expected (it directs users to Snippets)
  • Some URL params are being kept when changing tabs that should be cleared

How to test

Test setup required:

  • Enable Advanced Search in GDK and in Admin Settings
  • Index all projects (or a single test project)

unsupported params

params specific to a tab

resetting filters

Screenshots (strongly suggested)

Tab with filter set image

Clicked another tab image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu

Merge request reports