Skip to content

Fix unencoded octothorpes (and spaces) in Image Diff URLs

What does this MR do?

For #285101 (closed)

Escapes most characters that might break a URL (especially: #)

Problem

Some images in projects have # characters that cause the request to load that image to fail.

Solution

By encoding those characters, the image load succeeds. Initially, this encoding uses encodeURIComponent, with a few special overrides.
Notably, these overrides are defined in an explicit list, which makes them clear to modify if needed in the future.

Screenshots (strongly suggested)

Before After
image after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph

Merge request reports