Skip to content

Remove non-existing gitlab pages params

Alexandr Tanayno requested to merge docs-remove-pages-params into master

What does this MR do?

The doc section Global settings contains the reference to the gitlab.rb options gitlab_pages['ssl_certificate'] and gitlab_pages['ssl_certificate_key'] but seems that they do not exist:

  • when wildcard DNS with TLS is used, one should set pages_nginx['ssl_certificate'] & pages_nginx['ssl_certificate_key']
  • when custom domains with TLS are used, one should set gitlab_pages['cert'] & gitlab_pages['cert_key']

This MR removes gitlab_pages['ssl_certificate'] and gitlab_pages['ssl_certificate_key'] from the docs.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexandr Tanayno

Merge request reports