Skip to content

Geo: Refactor FileDownloadDispatchWorker JobFinders and FileRegistryFinders

Michael Kozono requested to merge mk/geo/refactor-job-finders into master

What does this MR do?

Reduces technical debt noted in https://gitlab.com/gitlab-org/gitlab-ee/issues/5601.

The previous MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5050 was merged under this condition.

Code quality improved on 12 points and degraded on 34 points

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary No changelog because no change in behavior
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Resolves https://gitlab.com/gitlab-org/gitlab-ee/issues/5601

Edited by Nick Thomas

Merge request reports