Skip to content

Introduce report type in pipeline artifact

Max Orefice requested to merge mo-refactor-pipeline-artifact-2 into master

What does this MR do?

This MR refactors our pipeline artifacts by renaming methods for a better abstraction.

It includes the following items:

  • Renames has_report? to report_exist?
  • Adds missing test for our new presenter class

Why are we doing this?

As brought up by @shinya.maeda we need a better abstraction to generalize the way we differentiate our REPORT_TYPES generated by the system.

As our application keeps growing, it's important to refactor our codebase to better express what it actually does. Things change and something that could have made sense few months ago is not necessary true today.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports