Skip to content

[MR Page] Migrate to GlModal for Cherry-pick MR

What does this MR do?

  • Replaces non-pajamas CHERRY-PICK modal with the GlModal from pajamas for a merged merge request.
  • Removes temporary toggling between pajamas as this is the last item to convert.
  • Removes non-pajamas modal template.

Screenshots (strongly suggested)

Images

action before after
view button Screen_Shot_2021-02-02_at_3.26.16_PM Screen_Shot_2021-02-02_at_4.15.03_PM
click button Screen_Shot_2021-02-02_at_3.26.58_PM Screen_Shot_2021-02-02_at_4.14.56_PM
show dropdown Screen_Shot_2021-02-02_at_3.27.25_PM Screen_Shot_2021-02-02_at_4.14.30_PM

Videos

Screen_Recording_2021-02-02_at_3.41.47_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #229679

Edited by Doug Stull

Merge request reports